Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback speed control #436

Open
sifferhans opened this issue Jun 9, 2024 · 4 comments
Open

Playback speed control #436

sifferhans opened this issue Jun 9, 2024 · 4 comments
Labels
help wanted Community can help with implementing this

Comments

@sifferhans
Copy link
Collaborator

I got feedback that someone missed the playback speed controls of the mobile app. Is this something that can be designed and implemented?

@sifferhans sifferhans changed the title Speed control Playback speed control Jun 9, 2024
@SimonSimCity
Copy link
Collaborator

Implementation seems possible (https://developer.mozilla.org/en-US/docs/Web/Media/Audio_and_video_delivery/WebAudio_playbackRate_explained). Just mind the limitations in the the sections Note: (only when paused on iOS 9 and it's recommended that you limit the range to between 0.5 and 4).

@kkuepper
Copy link
Member

kkuepper commented Jun 10, 2024

I suggest using the same simple design from the mobile app:
add "Playback speed" as an option when clicking the 3 dots in the top right of the player.

On BMM Web, spoken content is 18% of consumed content (vs 49% on mobile). Therefore I didn't push to add playback speed as a dedicated button on the player.

@SimonSimCity
Copy link
Collaborator

@kkuepper Should it be remembered, or is there a time/condition by which it should be resetted?

@kkuepper
Copy link
Member

kkuepper commented Jun 11, 2024

  1. If you start playing a playlist of messages, it should apply the playback speed to all of them.
  2. If you click on a song afterwards, it should be reset to normal speed.

I don't remember what happens in the app, if you have a mixed list (e.g. meeting with singsong and messages). I recommend testing different scenarios in the mobile app before implementing it. But it's also not a problem if it behaves differently as long as the 2 rules from above are working.

@kkuepper kkuepper added help wanted Community can help with implementing this and removed missing design spec labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community can help with implementing this
Projects
None yet
Development

No branches or pull requests

3 participants