Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove line with "must be non-empty array" text for drop file fields that are left blank and validated #4290

Open
astridSABC opened this issue Jan 24, 2025 · 1 comment
Labels
Bug Something isn't working Student Student Features

Comments

@astridSABC
Copy link
Collaborator

astridSABC commented Jan 24, 2025

Describe the Bug
"must be non-empty array" text is in the red warning messages at the top of the page and drop files box when left blank and validated for all drop fields

Expected Behaviour
Only text such as "Proof of citizenship document is required. Please provide at least one file to be uploaded"

Actual Behaviour
One sentence has "must be non-empty array" at the top of the page and within the drop file box

E.g.
Upload supporting documents: must be non-empty array
Upload supporting documents: is required

image.png

image.png

** Steps To Reproduce**
Steps to reproduce the behaviour:

  1. Login to a student account
  2. Click "start application"
  3. Select Personal information tab
  4. Select "Protected person"
  5. Select "No" for BC resident
  6. Click "Next"
  7. Scroll to the top of the page for the warnings for missing information
  8. Scroll to each section and note the first line of red text in the drop field box
  9. Review all drop box field validation for same errors
@astridSABC astridSABC added Business Items under Business Consideration Enhancement New feature or request Student Student Features Task Usability labels Jan 24, 2025
@astridSABC astridSABC added Bug Something isn't working and removed Enhancement New feature or request Business Items under Business Consideration Usability labels Jan 24, 2025
@astridSABC astridSABC removed this from the 3.X Post Full-Time Priorities milestone Jan 24, 2025
@astridSABC astridSABC changed the title Copy of Content: Remove line with "must be non-empty array" text for drop file fields that are left blank and add titles to drop fields Bug: Remove line with "must be non-empty array" text for drop file fields that are left blank Jan 24, 2025
@astridSABC astridSABC removed the Task label Jan 24, 2025
@astridSABC astridSABC changed the title Bug: Remove line with "must be non-empty array" text for drop file fields that are left blank Bug: Remove line with "must be non-empty array" text for drop file fields that are left blank and validated Jan 24, 2025
@CarlyCotton
Copy link
Collaborator

Moving to SOAP as a 3.0 to review error messaging on the required doc uploaders so message is more user friendly and not contradictory.

@CarlyCotton CarlyCotton added this to the Full-Time Students MVP milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Student Student Features
Projects
None yet
Development

No branches or pull requests

2 participants