Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Smoke Tests in Name-Examination #22417

Closed
EPortman opened this issue Jul 23, 2024 · 3 comments
Closed

Clean up Smoke Tests in Name-Examination #22417

EPortman opened this issue Jul 23, 2024 · 3 comments
Assignees
@EPortman
Labels
Names Team Name Request Name Examination Team

Comments

@EPortman
Copy link
Collaborator

Some Smoke tests for Name Request UI are located in Name Examination UI. Remove these tests.

Also one of the tests in /smoke-20-e2e.cy.ts seems to not be stable after changes to the queue toggle. It sometimes fails, especially in the GitHub run, when checking to see if the toggle is clickable (which it is, this should not be failing).

Cypress just needs to wait a little bit before clicking the toggle and then assert that the value has changed.
@EPortman EPortman added the Names Team Name Request Name Examination Team label Jul 23, 2024
@ozamani9gh ozamani9gh mentioned this issue Jul 24, 2024
Closed
@ozamani9gh
Copy link
Collaborator

waiting on Patrick Wei

1 similar comment
@ozamani9gh
Copy link
Collaborator

waiting on Patrick Wei

@ozamani9gh ozamani9gh mentioned this issue Aug 7, 2024
Closed
@EPortman
Copy link
Collaborator Author

bcgov/name-examination#1533

@ozamani9gh ozamani9gh mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EPortman EPortman

Labels
Names Team Name Request Name Examination Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ozamani9gh @EPortman