Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3347] User Role Request Update pt2 #3382

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Jul 18, 2024

Overview

This PR includes the following proposed change(s):

  • Eliminate prop hook for if user is updating their role, moved to use authState instead.
  • Set status for update requests to always be NOT_APPROVED by default.
  • Verify before submitting a request that The user submitting the request:
    1. Is the user the request is for (compare request to token)
    2. Currently is an active user * (Avoid bypassing any accesses)*

Note

I falsely believed that having the first PR merged would eliminate it showing the changes in this PR. I hoped this would be a little more DRY

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@micheal-w-wells micheal-w-wells merged commit 5d99d21 into dev Jul 22, 2024
5 of 9 checks passed
@LocalNewsTV LocalNewsTV deleted the admin-access-updates-pt2 branch August 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update my info button sends an access request instead of an update request
2 participants