Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional checks in batch uploader #3398

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Aug 1, 2024

Overview

This PR includes the following proposed change(s):

  • linked_id is optional, if a shortId is not provided, skip the validation
  • If shortID is not properly formatted, exit early citing issue.
  • Sever database connections at end of functions

How it was tested

  1. Got CSV used to cause the original crash
  2. Added proper error handling so it passed without crash/hang
  3. Added Invalid ShortIDs so first rounds of checks would pass, then address hangups from subsequent ones

Will better handle when now when ShortID:

  • Missing
  • Malformed
  • Yields no results

Copy link

sonarqubecloud bot commented Aug 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
16.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@plasticviking plasticviking merged commit 4f4006b into dev Aug 2, 2024
5 of 9 checks passed
@LocalNewsTV LocalNewsTV deleted the skip-linked-id-when-empty branch August 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants