From aee33cb283ce88671118367bad551b3385086a34 Mon Sep 17 00:00:00 2001 From: Joshua Burton Date: Thu, 21 Nov 2024 14:36:26 -0800 Subject: [PATCH] Adding a null check to the whole AddressDoctor response object. HTTP errors cause this object to not be filled, thus leading to a null pointer exception --- .../addressdoctor/service/AddressDoctorValidation.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/backend/app/src/main/java/com/moh/phlat/backend/addressdoctor/service/AddressDoctorValidation.java b/backend/app/src/main/java/com/moh/phlat/backend/addressdoctor/service/AddressDoctorValidation.java index 1396b7b..60355dd 100644 --- a/backend/app/src/main/java/com/moh/phlat/backend/addressdoctor/service/AddressDoctorValidation.java +++ b/backend/app/src/main/java/com/moh/phlat/backend/addressdoctor/service/AddressDoctorValidation.java @@ -102,6 +102,12 @@ private AddressDoctorResults processAddressDoctorResults(SOAPEnvelopeOutput addr AddressDoctorResults addressDoctorResults = new AddressDoctorResults(); + if (addressDoctorResponse == null) { + addError(processData, "ValidationError", "ERROR", "Could not reach or get a response from the AddressDoctor service"); + addressDoctorResults.setError(true); + return addressDoctorResults; + } + SOAPBodyOutput soapBody = addressDoctorResponse.getSoapBody(); if (soapBody == null) { logger.error("The SOAP Body message is missing due to a possible PHLAT misconfiguration or an issue with AddressDoctor");