Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before I add more code smells and refactorings #7

Open
professor opened this issue Nov 8, 2019 · 0 comments
Open

Before I add more code smells and refactorings #7

professor opened this issue Nov 8, 2019 · 0 comments

Comments

@professor
Copy link
Collaborator

I started looking into the remaining of the 66 refactorings.

So far, I'm not convinced that they all have value or are at the same level of abstraction and/or usefulness.

a. I checked out Pull Up Method which seems too similar to Push Down Method and Pull Up Field / Push Down Field. I kinda want to treat these ar the same kind of refactoring.

b. I checked out Decompose Conditional (259). Fowler points out that it is a special case of "Extract Method" --- not sure if that means that it warrants its own.

I wonder if sorting on "frequency of use" or value might be better. Common vs rare?

I'm curious why "Move Method," "Extract Method" etc were renamed to ___ Field.

Do we have a smell around "Inheritance instead of composition" ? Many of the refactorings seem to revolve around moving methods in the class hierarchy and this feels so mid-2000s Java.

If we keed the pull/push method/attribute, I'm thinking the smell is about the wrong level of abstraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant