From e1fd4713ff921e1af7660bd7b728db1ec77fac25 Mon Sep 17 00:00:00 2001 From: benibela Date: Sat, 8 Jan 2022 18:11:24 +0100 Subject: [PATCH] fix useless warnings --- applicationconfig.pas | 9 +++--- bibtexexport.pas | 2 +- bookSearchForm.pas | 4 +-- booklistreader.pas | 1 + bookwatchmain.pas | 24 ++++++++-------- duplicateremover.pas | 8 +++--- exportxml.pas | 4 ++- libraryparser.pas | 6 ++-- librarysearcheraccess.pas | 3 -- newaccountwizard_u.lfm | 3 -- newaccountwizard_u.pas | 31 +++------------------ options.lfm | 5 +--- options.pas | 58 ++++----------------------------------- 13 files changed, 42 insertions(+), 116 deletions(-) diff --git a/applicationconfig.pas b/applicationconfig.pas index db9c542c7..e67a31b20 100755 --- a/applicationconfig.pas +++ b/applicationconfig.pas @@ -321,10 +321,11 @@ implementation end; type TInternetAccessReact = object - procedure internetReact(sender: TInternetAccess; var transfer: TTransfer; var reaction: TInternetAccessReaction); + procedure internetReact(sender: TInternetAccess; var {%H-}transfer: TTransfer; var reaction: TInternetAccessReaction); end; procedure TInternetAccessReact.internetReact(sender: TInternetAccess; var transfer: TTransfer; var reaction: TInternetAccessReaction); begin + ignore(sender); if reaction = iarFollowRedirectGET then reaction := iarFollowRedirectKeepMethod; end; @@ -731,9 +732,9 @@ type EInitializationError = class(Exception); -class procedure TCallbackHolder.updateAutostart(enabled, askBeforeChange: boolean); begin end; -class procedure TCallbackHolder.applicationUpdate(auto: boolean); begin end; -class procedure TCallbackHolder.statusChange(const message: string); begin end; +class procedure TCallbackHolder.updateAutostart(enabled, askBeforeChange: boolean); begin ignore(enabled); ignore(askBeforeChange); end; +class procedure TCallbackHolder.applicationUpdate(auto: boolean); begin ignore(auto); end; +class procedure TCallbackHolder.statusChange(const message: string); begin ignore(message); end; class procedure TCallbackHolder.allThreadsDone; begin end; class procedure TCallbackHolder.postInitApplication; begin end; diff --git a/bibtexexport.pas b/bibtexexport.pas index ee0aae03a..19e0fb433 100755 --- a/bibtexexport.pas +++ b/bibtexexport.pas @@ -45,7 +45,7 @@ TBibTexExportFrm = class(TVideLibriForm) BibTexExportFrm: TBibTexExportFrm; implementation -uses bbutils, bbutilsbeta, applicationconfig, bookWatchMain,booklistreader,Clipbrd,math,applicationdesktopconfig, xquery__serialization_nodes,xquery.internals.common; +uses bbutils, bbutilsbeta, applicationconfig, bookWatchMain,booklistreader,Clipbrd, xquery__serialization_nodes,xquery.internals.common; { TBibTexExportFrm } type TBibTeXIDFormats = ( diff --git a/bookSearchForm.pas b/bookSearchForm.pas index 14196507e..057770d40 100755 --- a/bookSearchForm.pas +++ b/bookSearchForm.pas @@ -151,13 +151,10 @@ implementation rsSearchingDetails = 'Suche Details für dieses Medium...'; rsLoadingNextPage = 'Lade nächste Seite...'; rsSearchComplete = 'Suche abgeschlossen'; - rsNoSelection = 'Kein Medium ausgewählt'; - rsNoLinkKnown = 'Leider kann ich das ausgewählte Medium nicht in dieser Seite öffnen, da ich den nötigen Link nicht kenne'; rsSearchingCover = 'Suche Titelbild...'; rsSearchPartiallyComplete = 'Suche abgeschlossen (mehr Ergebnisse verfügbar)'; rsExistsOverrideConfirm = 'Das Medium existiert bereits als "%s", soll es mit "%s" überschrieben werden?'; rsOverrideConfirm = 'Soll das markierte Medium "%s" mit "%s" überschrieben werden?'; - rsChooseOrder = 'Es gibt mehrere vormerkbare/Bestellbare Exemplare. Welches wollen Sie?'; rsNoHoldingSelected = 'Es wurde nicht ausgewählt, welches Exemplar bestellt werden soll. (in der unteren Liste)'; rsOrderConfirm = 'Soll "%s" bestellt werden?'; rsOrderComplete = 'Das Buch "%s" wurde ohne Fehler vorgemerkt. %s'; @@ -720,6 +717,7 @@ procedure TbookSearchFrm.FormDestroy(Sender: TObject); procedure TbookSearchFrm.searcherAccessDetailsComplete(sender: TObject; book: TBook); begin + ignore(book); if sender <> searcherAccess then exit; if (displayDetails() < 2) and (displayImage.Checked) then begin StatusBar1.Panels[SB_PANEL_SEARCH_STATUS].Text:=rsSearchingCover; diff --git a/booklistreader.pas b/booklistreader.pas index 2b4ffed81..6fe27017d 100755 --- a/booklistreader.pas +++ b/booklistreader.pas @@ -1016,6 +1016,7 @@ procedure TBookListReader.logall(sender: TMultipageTemplateReader; logged: strin procedure TBookListReader.TraceEvent(sender: TXQueryEngine; value, info: IXQValue); begin if not logging then exit; + ignore(sender); log(info.toString+ ': ' + value.toXQuery) end; diff --git a/bookwatchmain.pas b/bookwatchmain.pas index 59116e856..8fc68db99 100755 --- a/bookwatchmain.pas +++ b/bookwatchmain.pas @@ -8,8 +8,8 @@ interface uses Classes, SysUtils, LResources, Forms, Controls, Graphics, Dialogs, StdCtrls, Buttons, libraryParser, internetAccess, ComCtrls, Menus, lmessages, ExtCtrls, - errorDialog, statistik_u, libraryAccess, sendBackError, Translations, - progressDialog, bookListView, TreeListView, bookSearchForm, LCLType, lclproc, + statistik_u, libraryAccess, sendBackError, Translations, + bookListView, TreeListView, bookSearchForm, LCLType, lclproc, LCLIntf, process, applicationconfig,exportxml,applicationdesktopconfig,applicationformconfig; const //automaticExtend=true; @@ -102,19 +102,19 @@ TmainForm = class(TVideLibriForm) procedure accountsChanged(Sender: TObject); procedure androidActivationTimerTimer(Sender: TObject); procedure bookPopupMenuPopup(Sender: TObject); - procedure BookListUserSortItemsEvent(sender: TObject; - var sortColumn: longint; var invertSorting: boolean); + procedure BookListUserSortItemsEvent({%H-}sender: TObject; + var {%H-}sortColumn: longint; var {%H-}invertSorting: boolean); procedure cancelTheseBooksClick(Sender: TObject); procedure dailyCheckThreadTimer(Sender: TObject); procedure delayedCallTimer(Sender: TObject); procedure EnsureTrayIconTimerTimer(Sender: TObject); procedure extendAdjacentBooksClick(Sender: TObject); procedure FormActivate(Sender: TObject); - procedure FormClose(Sender: TObject; var CloseAction: TCloseAction); + procedure FormClose(Sender: TObject; var {%H-}CloseAction: TCloseAction); procedure FormCreate(Sender: TObject); procedure FormDestroy(Sender: TObject); procedure FormResize(Sender: TObject); - procedure BookListSelectItem(Sender: TObject; Item: TTreeListItem); + procedure BookListSelectItem(Sender: TObject; {%H-}Item: TTreeListItem); procedure FormShow(Sender: TObject); procedure FormWindowStateChange(Sender: TObject); procedure menuDuplicateCheckerClick(Sender: TObject); @@ -141,8 +141,8 @@ TmainForm = class(TVideLibriForm) procedure removeSelectedMIClick(Sender: TObject); procedure displayDetailsMIClick(Sender: TObject); procedure repeatedCheckTimerTimer(Sender: TObject); - procedure searchTextKeyDown(Sender: TObject; var Key: Word; - Shift: TShiftState); + procedure searchTextKeyDown(Sender: TObject; var {%H-}Key: Word; + {%H-}Shift: TShiftState); procedure TrayIcon1Click(Sender: TObject); procedure TrayIcon1DblClick(Sender: TObject); procedure TrayIconClickTimer(Sender: TObject); @@ -153,7 +153,7 @@ TmainForm = class(TVideLibriForm) procedure MenuItem6Click(Sender: TObject); procedure MenuItem8Click(Sender: TObject); procedure searchCloseClick(Sender: TObject); - procedure searchTextKeyUp(Sender: TObject; var Key: Word; Shift: TShiftState + procedure searchTextKeyUp(Sender: TObject; var {%H-}Key: Word; {%H-}Shift: TShiftState ); procedure searchUpClick(Sender: TObject); procedure showAccount(Sender: TObject); @@ -163,7 +163,7 @@ TmainForm = class(TVideLibriForm) procedure Timer1Timer(Sender: TObject); procedure ShowOptionsClick(Sender: TObject); procedure btnRefreshClick(Sender: TObject); - procedure ToolButton2ContextPopup(Sender: TObject; MousePos: TPoint; + procedure ToolButton2ContextPopup(Sender: TObject; {%H-}MousePos: TPoint; var Handled: Boolean); procedure ToolButton3Click(Sender: TObject); procedure ViewAllClick(Sender: TObject); @@ -187,7 +187,7 @@ TmainForm = class(TVideLibriForm) procedure BookListDblClick(Sender: TObject); procedure BookListEditingDone(Sender: TObject); - procedure BookListMouseDown(Sender: TObject; Button: TMouseButton; Shift: TShiftState; X, Y: Integer); + procedure BookListMouseDown(Sender: TObject; {%H-}Button: TMouseButton; Shift: TShiftState; X, {%H-}Y: Integer); procedure setPanelText(panel: TStatusPanel; atext: string); procedure ThreadDone(Sender: TObject); procedure RefreshListView; //Zentrale Anzeige Funktion! @@ -201,7 +201,7 @@ TmainForm = class(TVideLibriForm) function IsShortcut(var Message: TLMKey): boolean; override; - procedure showVidelibri(var m:lcltype.TMsg); message LM_SHOW_VIDELIBRI; + procedure showVidelibri(var {%H-}m:lcltype.TMsg); message LM_SHOW_VIDELIBRI; procedure showMainwindow; end; diff --git a/duplicateremover.pas b/duplicateremover.pas index 3cddc49f9..92496aff6 100644 --- a/duplicateremover.pas +++ b/duplicateremover.pas @@ -28,10 +28,10 @@ TduplicateForm = class(TVideLibriForm) { public declarations } listview: TBookListView; totalcount,checkedcount: integer; - procedure itemPositioning(sender: TObject; visualColumnIndex: integer; recordItem: TTreeListRecordItem; var aposition: TRect); - procedure listviewCustomRecordItemDraw(sender: TObject; eventTyp_cdet: TCustomDrawEventTyp; recordItem: TTreeListRecordItem; - var defaultDraw: Boolean); - procedure listviewMouseDown(Sender: TObject; Button: TMouseButton; Shift: TShiftState; X, Y: Integer); + procedure itemPositioning({%H-}sender: TObject; {%H-}visualColumnIndex: integer; recordItem: TTreeListRecordItem; var aposition: TRect); + procedure listviewCustomRecordItemDraw({%H-}sender: TObject; eventTyp_cdet: TCustomDrawEventTyp; recordItem: TTreeListRecordItem; + var {%H-}defaultDraw: Boolean); + procedure listviewMouseDown(Sender: TObject; {%H-}Button: TMouseButton; {%H-}Shift: TShiftState; X, Y: Integer); procedure searchDuplicates; end; diff --git a/exportxml.pas b/exportxml.pas index b141e8f71..fa29b55e6 100644 --- a/exportxml.pas +++ b/exportxml.pas @@ -47,7 +47,7 @@ TXMLExportFrm = class(TVideLibriForm) XMLExportFrm: TXMLExportFrm; implementation -uses strutils,bookWatchMain,libraryAccess,applicationdesktopconfig; +uses strutils,bookWatchMain,libraryAccess, bbutils; const COLUMN_CURRENT = 1; COLUMN_HISTORY = 2; @@ -236,6 +236,7 @@ procedure TXMLExportFrm.TreeListView1ClickAtRecordItem(sender: TObject; recordit j: Integer; begin + ignore(sender); TreeListView1.BeginUpdate; try col := recorditem.Index; @@ -303,6 +304,7 @@ procedure TXMLExportFrm.TreeListView1CustomRecordItemDraw(sender: TObject; event w: Integer; cbText: String; begin + ignore(sender); drawCB := false; if recordItem.Index = 0 then begin if eventTyp_cdet = cdetPrePaint then begin diff --git a/libraryparser.pas b/libraryparser.pas index 9702096d0..ddc481d80 100755 --- a/libraryparser.pas +++ b/libraryparser.pas @@ -474,7 +474,9 @@ procedure importAccountsPrepare(const fn: string; out parser: TTreeParser; out a hasPass := xq.parseXPath3('./config/base/v[@n="pass"]'); hasCurrent := xq.parseXPath3('./books[@mode="current"]'); hasHistory := xq.parseXPath3('./books[@mode="history"]'); + accounts := nil; SetLength(accounts, tempv.Count); + flags := nil; SetLength(flags, tempv.Count); for i := 0 to high(accounts) do begin xv := tempv.get(i+1); @@ -526,8 +528,8 @@ procedure importAccounts(parser: TTreeParser; impAccounts: TStringArray; flags: end; -var realAccounts: array of TCustomAccountAccess; - accountNodes: array of TTreeNode; +var realAccounts: array of TCustomAccountAccess = nil; + accountNodes: array of TTreeNode = nil; i, j: Integer; xq: TXQueryEngine; getAccoutNode: IXQuery; diff --git a/librarysearcheraccess.pas b/librarysearcheraccess.pas index 7ad73c220..39b3edca2 100644 --- a/librarysearcheraccess.pas +++ b/librarysearcheraccess.pas @@ -468,11 +468,8 @@ procedure TSearcherThread.callPendingMessageEvent(event: TPendingMessageEvent; b procedure TSearcherThread.execute; var mes: TSearcherMessage; - temp, image:string; book: tbook; debugLastSearchQuery: String; - oldUrl: String; - images: TStringArray; newsearcher: TLibrarySearcher; begin newsearcher := TLibrarySearcher.create(access.ftemplate); diff --git a/newaccountwizard_u.lfm b/newaccountwizard_u.lfm index e22e64756..fedc3bc80 100644 --- a/newaccountwizard_u.lfm +++ b/newaccountwizard_u.lfm @@ -53,8 +53,6 @@ object newAccountWizard: TnewAccountWizard end end object Page2: TPage - OnBeforeShow = Page2BeforeShow - OnMouseUp = Page2MouseUp object Label4: TLabel AnchorSideTop.Control = accountName AnchorSideTop.Side = asrCenter @@ -263,7 +261,6 @@ object newAccountWizard: TnewAccountWizard end end object Page4: TPage - OnBeforeShow = Page4BeforeShow object lblWarning: TLabel AnchorSideLeft.Control = extendTypeRG AnchorSideLeft.Side = asrBottom diff --git a/newaccountwizard_u.pas b/newaccountwizard_u.pas index b60623424..bf2857fd1 100644 --- a/newaccountwizard_u.pas +++ b/newaccountwizard_u.pas @@ -6,7 +6,7 @@ interface uses Classes, SysUtils, LResources, Forms, Controls, Graphics, Dialogs, ExtCtrls, - Buttons, StdCtrls, Grids,bookwatchmain,libraryParser, libraryListView, TreeListView,applicationformconfig; + Buttons, StdCtrls, libraryParser, libraryListView, TreeListView,applicationformconfig; type @@ -61,12 +61,6 @@ TnewAccountWizard = class(TVideLibriForm) procedure locationListChange(Sender: TObject); procedure newlibbtnClick(Sender: TObject); procedure Notebook1PageChanged(Sender: TObject); - procedure Page2BeforeShow(ASender: TObject; ANewPage: TPage; - ANewIndex: Integer); - procedure Page2MouseUp(Sender: TObject; Button: TMouseButton; Shift: TShiftState; X, Y: Integer); - procedure Page4BeforeShow(ASender: TObject; ANewPage: TPage; - ANewIndex: Integer); - procedure RadioGroup1Click(Sender: TObject); procedure RadioGroup2Click(Sender: TObject); procedure Timer1Timer(Sender: TObject); private @@ -83,7 +77,7 @@ TnewAccountWizard = class(TVideLibriForm) newAccountWizard: TnewAccountWizard; implementation -uses applicationconfig,applicationdesktopconfig, libraryaccess,internetAccess,LCLProc,bbdebugtools, options; +uses applicationconfig,applicationdesktopconfig, libraryaccess,internetAccess,LCLProc,bbdebugtools, options, bbutils; { TnewAccountWizard } @@ -176,6 +170,8 @@ procedure TnewAccountWizard.libsSelect(sender: TObject; item: TTreeListItem); var selectedLibrary: TLibrary; begin + ignore(sender); + ignore(item); selectedLibrary:=libs.selectedLibrary; if selectedLibrary = nil then exit; @@ -253,25 +249,6 @@ procedure TnewAccountWizard.Notebook1PageChanged(Sender: TObject); extendTypeRG.ReAlign; end; -procedure TnewAccountWizard.Page2BeforeShow(ASender: TObject; ANewPage: TPage; - ANewIndex: Integer); -begin - -end; - -procedure TnewAccountWizard.Page2MouseUp(Sender: TObject; Button: TMouseButton; Shift: TShiftState; X, Y: Integer); -begin -end; - -procedure TnewAccountWizard.Page4BeforeShow(ASender: TObject; ANewPage: TPage; - ANewIndex: Integer); -begin - -end; - -procedure TnewAccountWizard.RadioGroup1Click(Sender: TObject); -begin -end; procedure TnewAccountWizard.RadioGroup2Click(Sender: TObject); var extendType: TExtendType; diff --git a/options.lfm b/options.lfm index e32472a91..dab5c6063 100755 --- a/options.lfm +++ b/options.lfm @@ -37,10 +37,9 @@ object optionForm: ToptionForm Height = 505 Top = 6 Width = 597 - PageIndex = 5 + PageIndex = 0 Anchors = [akTop, akLeft, akRight, akBottom] BorderSpacing.Around = 2 - OnChangeBounds = Notebook1ChangeBounds TabOrder = 0 TabStop = True object pageAccount: TPage @@ -1518,7 +1517,6 @@ object optionForm: ToptionForm ClientHeight = 468 ClientWidth = 593 TabOrder = 0 - OnClick = Panel4Click object libList: TListView AnchorSideBottom.Control = libxml Left = 4 @@ -1665,7 +1663,6 @@ object optionForm: ToptionForm ClientHeight = 461 ClientWidth = 593 TabOrder = 0 - OnClick = Panel5Click object templatexml: TMemo AnchorSideBottom.Control = templateDefine Left = 122 diff --git a/options.pas b/options.pas index def1f3ae4..e7a543f61 100755 --- a/options.pas +++ b/options.pas @@ -191,24 +191,14 @@ ToptionForm = class(TVideLibriForm) procedure FormShow(Sender: TObject); procedure ImageList1Change(Sender: TObject); procedure lblShowWarningClick(Sender: TObject); - procedure ListView2Change(Sender: TObject; Item: TListItem; - Change: TItemChange); - procedure ListView2Click(Sender: TObject); - procedure ListView2SelectItem(Sender: TObject; Item: TListItem; - Selected: Boolean); procedure mailaddClick(Sender: TObject); procedure maildelClick(Sender: TObject); procedure mailListSelectItem(Sender: TObject; Item: TListItem; Selected: Boolean); procedure mailsetClick(Sender: TObject); - procedure Notebook1ChangeBounds(Sender: TObject); - procedure Notebook1Changing(Sender: TObject; var AllowChange: Boolean); - procedure Notebook1PageChanged(Sender: TObject); - procedure Panel4Click(Sender: TObject); - procedure Panel5Click(Sender: TObject); - procedure Shape1MouseUp(Sender: TOBject; Button: TMouseButton; - Shift: TShiftState; X, Y: Integer); + procedure Shape1MouseUp(Sender: TOBject; {%H-}Button: TMouseButton; + {%H-}Shift: TShiftState; {%H-}X, {%H-}Y: Integer); procedure SpeedButton1Click(Sender: TObject); - procedure templateListSelectionChange(Sender: TObject; User: boolean); + procedure templateListSelectionChange(Sender: TObject; {%H-}User: boolean); procedure TrackBar1Change(Sender: TObject); procedure TrackBar2Change(Sender: TObject); @@ -585,20 +575,6 @@ procedure ToptionForm.Button8Click(Sender: TObject); begin end; -procedure ToptionForm.ListView2Change(Sender: TObject; Item: TListItem; - Change: TItemChange); -begin -end; - -procedure ToptionForm.ListView2Click(Sender: TObject); -begin - -end; - -procedure ToptionForm.ListView2SelectItem(Sender: TObject; Item: TListItem; - Selected: Boolean); -begin -end; procedure ToptionForm.mailaddClick(Sender: TObject); begin @@ -617,6 +593,9 @@ procedure ToptionForm.maildelClick(Sender: TObject); procedure ToptionForm.mailListSelectItem(Sender: TObject; Item: TListItem; Selected: Boolean); begin + ignore(sender); + ignore(item); + ignore(selected); if (mailList.Items.Count = 0) or (mailList.SelCount = 0) or (mailList.Selected=nil) then exit; @@ -640,31 +619,6 @@ procedure ToptionForm.mailsetClick(Sender: TObject); end; end; -procedure ToptionForm.Notebook1ChangeBounds(Sender: TObject); -begin - -end; - -procedure ToptionForm.Notebook1Changing(Sender: TObject; - var AllowChange: Boolean); -begin - -end; - -procedure ToptionForm.Notebook1PageChanged(Sender: TObject); -begin -end; - -procedure ToptionForm.Panel4Click(Sender: TObject); -begin - -end; - -procedure ToptionForm.Panel5Click(Sender: TObject); -begin - -end; - procedure ToptionForm.Shape1MouseUp(Sender: TOBject; Button: TMouseButton; Shift: TShiftState; X, Y: Integer); begin