Why doesn't image resize to fit the area?

[TadoTheMiner]

I am making an xkcd viewer. However, the comics are really tiny

Here is the render function:

fn render(&mut self) -> Result<()> {
        self.terminal.draw(|f| {
            let area = f.area();
            f.render_widget(
                Block::new()
                    .title_top(self.comic.date_uploaded.as_str().blue())
                    .title_top(
                        Line::styled(&self.comic.title, Style::new().yellow().bold()).centered(),
                    ),
                area,
            );
            let alt_text = Paragraph::new(self.comic.alt_text.as_str())
                .centered()
                .wrap(Wrap::default())
                .dark_gray();
            let alt_text_height = alt_text.line_count(area.width) as u16;
            let alt_text_area = Rect {
                y: area.height - alt_text_height,
                height: alt_text_height,
                ..area
            };
            f.render_widget(alt_text, alt_text_area);
            let image_area = Rect {
                y: area.y + 1,
                height: area.height - 1 - alt_text_height,
                ..area
            };

            let image = self
                .picker
                .new_protocol(
                    if self.invert_image {
                        invert_image(&self.comic.image)
                    } else {
                        self.comic.image.clone()
                    },
                    image_area,
                    Resize::Fit(None),
                )
                .expect("XKCD should always contain valid images");

            // The image widget.
            //TODO: resize the image
            let image_widget = Image::new(&image);
            f.render_widget(image_widget, image_area)
        })?;
        Ok(())
    }

Shouldn't the image resize?

[benjajaja]

I think this is a DPI issue. On my machine, images in ratatui-image indeed appear smaller than when viewed in an image program or the browser. Exactly 0.75 the size, as my wayland scale factor is 1.5.

I don't really know how to solve this, other than using some x11 and wayland crates to figure out the current DPI.

[benjajaja]

Closing as @TadoTheMiner has implemented Resize::Scale ❤️

Note that I believe that DPI does still have some impact, and it would be nice to have some info/documentation on what exactly different terminals do with it.