Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallible systems spamming warning log statements #17144

Open
Testare opened this issue Jan 4, 2025 · 2 comments
Open

Fallible systems spamming warning log statements #17144

Testare opened this issue Jan 4, 2025 · 2 comments
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples

Comments

@Testare
Copy link
Contributor

Testare commented Jan 4, 2025

Bevy version

0.15

[Optional] Relevant system information

Arch Linux

What you did

I'm using the RenderPlugin without the WindowsPlugin (Want to use GPU for a CLI tool)

What went wrong

I'm getting this message spammed in my logs each frame:

2025-01-04T16:55:33.895740Z  WARN bevy_ecs::system::function_system: bevy_ecs::event::reader::EventReader<bevy_window::event::WindowClosing> did not run because it requested inaccessible system parameter Res<Events<WindowClosing>>

According to the news posting, these warnings are supposed to happen only once at most.

Additional information

When I add the window feature and the event for WindowClosing, it changes to WindowResizing, and when I add that, it complains about missing resources for Render's camera_system. I could probably just add the WindowsPlugin or add all these resources, but since I don't actually want to create Windows it seems like a waste.

If I truly want the warnings gone I might create a PR in the future to make bevy_render's bevy_window dependency optional (since it is such a niche case I don't think it would be worth taking the core bevy developers' time), but I wanted to file a bug report since the fallible system warning being repeated ad-nauseum seems to be off spec.

@Testare Testare added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 4, 2025
@BenjaminBrienen BenjaminBrienen added A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in S-Needs-Design This issue requires design work to think about how it would best be accomplished X-Contentious There are nontrivial implications that should be thought through D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Jan 4, 2025
@BenjaminBrienen
Copy link
Contributor

The big question is whether bevy is supposed to support using bevy_render without windowing. This might be better stated as a feature request. I might be wrong, though. Maybe the warning spam can just be fixed.

@Testare
Copy link
Contributor Author

Testare commented Jan 4, 2025

Yeah, I tried to make it clear that I'm not expecting this weird use case of mine to be imminently supported. That would definitely be a feature request at least, but honestly I expect if I really wanted it I should probably make a PR myself.

However, the fallible system spamming is something that seems like generally undesirable behavior, and so I'm reporting THAT as a bug.

@mockersf mockersf added A-ECS Entities, components, systems, and events and removed A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in S-Needs-Design This issue requires design work to think about how it would best be accomplished X-Contentious There are nontrivial implications that should be thought through labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples
Projects
None yet
Development

No branches or pull requests

3 participants