Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run example validation jobs on ubuntu-latest #17169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Run example validation jobs on ubuntu-latest #17169

wants to merge 2 commits into from
+6 −6

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jan 5, 2025 •
edited
Loading

Objective

Fixes #17164

Solution

  • Switch to ubuntu-latest
  • Remove libegl1-mesa. It seems that whatever this was providing is now covered by other deps or their deps?

Testing

Tested over here by commenting out workflow if condition.

@rparrett rparrett changed the title Run example validation jobs on ubuntu-latest Run example validation jobs on ubuntu-latest Jan 5, 2025
@TimJentzsch TimJentzsch added A-Build-System Related to build systems or continuous integration O-Linux Specific to the Linux desktop operating system D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 5, 2025
@mockersf
Copy link
Member

mockersf commented Jan 5, 2025

oh nice, didn't try to just remove it to check if it works 😄

it should already mostly work, but it's blocked until January 17th as GitHub is rolling out the migration of ubuntu-latest to ubuntu-24.04: actions/runner-images#10636

@mockersf mockersf added the S-Blocked This cannot move forward until something else changes label Jan 5, 2025
@rparrett
Copy link
Contributor Author

rparrett commented Jan 5, 2025 •
edited
Loading

It looks like playwright also needs to be updated. See microsoft/playwright#30368

I previously only tested the vulkan job with an explicit runs-on: ubuntu-24.04, but tested both again over here.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 6, 2025
@stuart-cls stuart-cls mentioned this pull request Jan 6, 2025
Closed
@mockersf mockersf mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@TimJentzsch TimJentzsch TimJentzsch approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Linux Specific to the Linux desktop operating system S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example running on runner ubuntu-latest fails because of system dependency change
5 participants
@rparrett @mockersf @TimJentzsch @BenjaminBrienen @alice-i-cecile