-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planned updates for new timezone databases? #321
Comments
Yes. Sorry. Will update. |
I also stumbled on the bug. I rolled back the Asia/Hong_Kong timezone changes to match 2018i and it still hit the infinite loop. If I delete the Asia/Hong_Kong block it continues and dies on Asia/Jerusalem. |
I got timezone to build with the 2022c release of the timezone database. I had to make two kinds of changes. I patched a couple of rules back to what was in the 2018 tz database.
And I modified the zones.js to just ignore problems with February. One rule that went to 2029 somehow triggered the getUTCDay() == i (which was 4 for thursday) and getUTCMonth() was 2.
Maybe this might hint at what the problem is. |
Hi,
It looks like it's been a little while since you have updated this library. Do you plan to continue updating/maintaining it?
I made an attempt at updating the eggert dependency in order to pull in the 2019c release, but unfortunately ran into some build failures when running
make
- specifically, the script seems to go into an infinite loop somewhere in this function, when it reaches Asia/Hong_Kong. If you're able to provide some guidance on what might need to be updated to make the build work, I may be able to take a crack at submitting a patch.Thank you!
The text was updated successfully, but these errors were encountered: