From fd319588ab1d2d91021ea60392f91dbce7163a53 Mon Sep 17 00:00:00 2001
From: william fitzgerald <wfitzger@redhat.com>
Date: Thu, 11 May 2017 16:05:44 -0400
Subject: [PATCH] Refactor infra vm check_remove_from_provider method and test.

Refactored the check_remove_from_provider method for Infrastructure Vm retirement.
Updated tests.

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
---
 .../check_removed_from_provider.rb            | 44 ++++++++++--
 .../check_removed_from_provider_spec.rb       | 70 +++++++++++++++++++
 2 files changed, 107 insertions(+), 7 deletions(-)
 create mode 100644 spec/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider_spec.rb

diff --git a/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider.rb b/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider.rb
index 48c742e3e..3e6365f47 100644
--- a/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider.rb
+++ b/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider.rb
@@ -2,14 +2,44 @@
 # Description: This method checks to see if the VM has been removed from the provider
 #
 
-vm = $evm.root['vm']
+module ManageIQ
+  module Automate
+    module Infrastructure
+      module VM
+        module Retirement
+          module StateMachines
+            class CheckRemovedFromProvider
+              def initialize(handle = $evm)
+                @handle = handle
+              end
 
-$evm.root['ae_result'] = 'ok'
+              def main
+                check_removed_from_provider(vm)
+              end
 
-if vm && $evm.get_state_var('vm_removed_from_provider')
-  if vm.ext_management_system
-    vm.refresh
-    $evm.root['ae_result']     = 'retry'
-    $evm.root['ae_retry_interval'] = '60.seconds'
+              private
+
+              def vm
+                raise "ERROR - vm object not passed in" unless @handle.root['vm']
+                @handle.root['vm']
+              end
+
+              def check_removed_from_provider(vm)
+                @handle.root['ae_result'] = 'ok'
+                if vm.ext_management_system && @handle.get_state_var('vm_removed_from_provider')
+                  vm.refresh
+                  @handle.root['ae_result'] = 'retry'
+                  @handle.root['ae_retry_interval'] = '60.seconds'
+                end
+              end
+            end
+          end
+        end
+      end
+    end
   end
 end
+
+if __FILE__ == $PROGRAM_NAME
+  ManageIQ::Automate::Infrastructure::VM::Retirement::StateMachines::CheckRemovedFromProvider.new.main
+end
diff --git a/spec/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider_spec.rb b/spec/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider_spec.rb
new file mode 100644
index 000000000..c451af954
--- /dev/null
+++ b/spec/content/automate/ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/check_removed_from_provider_spec.rb
@@ -0,0 +1,70 @@
+require_domain_file
+
+describe ManageIQ::Automate::Infrastructure::VM::Retirement::StateMachines::CheckRemovedFromProvider do
+  let(:ems)  { FactoryGirl.create(:ems_vmware, :zone => FactoryGirl.create(:zone)) }
+  let(:vm) { FactoryGirl.create(:vm_vmware, :ems_id => ems.id) }
+  let(:svc_model_vm) do
+    MiqAeMethodService::MiqAeServiceVm.find(vm.id)
+  end
+
+  let(:root_hash) do
+    {'vm' => svc_model_vm }
+  end
+
+  let(:root_object) do
+    Spec::Support::MiqAeMockObject.new(root_hash)
+  end
+
+  let(:ae_service) do
+    Spec::Support::MiqAeMockService.new(root_object).tap do |service|
+      current_object = Spec::Support::MiqAeMockObject.new
+      current_object.parent = root_object
+      service.object = current_object
+    end
+  end
+
+  it "returns 'retry' if vm, ems and state var true" do
+    ae_service.set_state_var('vm_removed_from_provider', true)
+    expect(svc_model_vm).to receive(:refresh)
+    described_class.new(ae_service).main
+    expect(ae_service.root['ae_result']).to eq('retry')
+  end
+
+  shared_examples_for "#state var" do
+    it "check" do
+      ae_service.set_state_var('vm_removed_from_provider', removed_from_provider)
+      described_class.new(ae_service).main
+      expect(ae_service.root['ae_result']).to eq(ae_result)
+    end
+  end
+
+  context "returns 'ok' if ems and state var false" do
+    let(:ae_result) { "ok" }
+    let(:removed_from_provider) { false }
+    it_behaves_like "#state var"
+  end
+
+  context "returns 'ok' if no ems and state var false" do
+    let(:vm) { FactoryGirl.create(:vm_vmware) }
+    let(:ae_result) { "ok" }
+    let(:removed_from_provider) { false }
+    it_behaves_like "#state var"
+  end
+
+  context "returns 'ok' if state var true" do
+    let(:vm) { FactoryGirl.create(:vm_vmware) }
+    let(:ae_result) { "ok" }
+    let(:removed_from_provider) { true }
+    it_behaves_like "#state var"
+  end
+
+  context "with no vm" do
+    let(:root_hash) { {} }
+
+    it "raises the vm is nil exception" do
+      expect { described_class.new(ae_service).main }.to raise_error(
+        'ERROR - vm object not passed in'
+      )
+    end
+  end
+end