Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .sf2 Files #32

Closed
rodydavis opened this issue Jan 27, 2019 · 7 comments
Closed

Support for .sf2 Files #32

rodydavis opened this issue Jan 27, 2019 · 7 comments

Comments

@rodydavis
Copy link

Would .sf2 files ever be a possibility?

@billthefarmer
Copy link
Owner

AFAIK, nobody has been able to get the code for loading DLS files to work - #21. DLS files are very similar to SF2 files, they use the same Amiga RIFF format, so they could be converted.

@rodydavis
Copy link
Author

Gotcha, is there a better format to use?

@billthefarmer
Copy link
Owner

If some clever soul out there can work out how to use the code in the Sonivox synthesizer for loading DLS files that would be possible. I think Google know how it works because they have fixed bugs in it.

@rodydavis
Copy link
Author

I was able to do this in my own Android MIDI Library with .SF2 files for future reference.

https://github.com/AppleEducate/MidiDriver-Android-SF2

I use this in a Flutter Plugin but this will work for all android projects.

@bmaupin
Copy link

bmaupin commented Feb 17, 2022

I was able to do this in my own Android MIDI Library with .SF2 files for future reference.

https://github.com/AppleEducate/MidiDriver-Android-SF2

I use this in a Flutter Plugin but this will work for all android projects.

@rodydavis Unfortunately this is a fork of KyoSherlock/MidiDriver, which has been improperly licensed: github.com/KyoSherlock/MidiDriver/issues/8

I'm not sure the best way to fix this. Would the upstream project need to be relicensed first? If it's unable to be fixed then it might be good to add a warning to your project as it shouldn't really be used until then.

(as I commented below, this is wrong)

@rodydavis
Copy link
Author

Yeah good point, the license is needed

@bmaupin
Copy link

bmaupin commented Feb 18, 2022

Yeah good point, the license is needed

I was wrong! 😅 It looks like that issue incorrectly stated that GPLv2 code was included in an Apache 2-licensed project, but it turns out the included code is actually GPLv2 with the classpath exception. So your project is fine. I think I'll probably try it out myself since this project isn't able to load sound fonts at the moment.

My biggest concern is that doing all this in Java instead of natively will be slow (e.g. KyoSherlock/MidiDriver#5) but I guess I'll find out soon enough...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants