Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Complex Parameter Validation #3

Open
ambsw-technology opened this issue Jul 6, 2020 · 1 comment
Open

Complex Parameter Validation #3

ambsw-technology opened this issue Jul 6, 2020 · 1 comment

Comments

@ambsw-technology
Copy link
Contributor

I'm working on a custom provider to fill in some gaps in WorkSpaces deployment. There are a bunch of CLI calls that can affect one of the resources (i.e. a directory service registered with WorkSpaces) that (as far as I can tell) need to be handled together. As a result, I have to accept both the general EnableSelfService as well as individual self-service permissions (e.g. IncreaseVolumeSize). If EnableSelfService is disabled, trying to allow IncreaseVolumeSize is invalid so I need to do some additional parameter validation.

At the moment, it looks like I should wrap is_valid_request and do my checks after super. If that's the right place, perhaps it makes sense to "document" it in the template e.g. a commented-out method that makes the super call and then has the comment # additional validation here. I can PR, but I want to make sure there isn't a by-design place to be doing this.

@ambsw-technology
Copy link
Contributor Author

ambsw-technology commented Jul 8, 2020

(posted in the wrong issue)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant