Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Don't Commit Pipfile.lock? #4

Open
ambsw-technology opened this issue Jul 13, 2020 · 1 comment
Open

Don't Commit Pipfile.lock? #4

ambsw-technology opened this issue Jul 13, 2020 · 1 comment

Comments

@ambsw-technology
Copy link
Contributor

I had never heard of pipenv but recently ran into an issue. I updated my upstream (fork) of cfn-resource-provider but didn't know to rerun pipenv lock so I was troubleshooting an issue that was fixed in upstream but frozen (on a broken version) in my Pipfile.lock. It seems to me that you wouldn't, in general, want to do this in the repo because it would prevent your package from ever picking up upstream fixes of any sort. The first time you make test, it should be generated and provide stability from that point forward.

@ambsw-technology
Copy link
Contributor Author

It's even possible that I made a change to the Pipfile but not the requirements.txt (which appear to control).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant