Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMDirT to 1.6.5 #53453

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update AMDirT to 1.6.5 #53453

merged 2 commits into from
Jan 24, 2025

Conversation

jfy133
Copy link
Contributor

@jfy133 jfy133 commented Jan 24, 2025

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jfy133
Copy link
Contributor Author

jfy133 commented Jan 24, 2025

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
noarch amdirt-1.6.5-pyhdfd78af_0.tar.bz2 noarch.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
amdirt 1.6.5--pyhdfd78af_0 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/amdirt---1.6.5--pyhdfd78af_0.tar.gz | docker load

@jfy133
Copy link
Contributor Author

jfy133 commented Jan 24, 2025

I need to check the package via artefacts is working before merging

@jfy133
Copy link
Contributor Author

jfy133 commented Jan 24, 2025

The tool isn't giving me protobuf warnings now, but validate seems to hang - any ideas @maxibor ?

@jfy133
Copy link
Contributor Author

jfy133 commented Jan 24, 2025

I will merge for now as other tools are working, and at least this makes AMDirT installable again.

But may require a patch release.

@jfy133 jfy133 merged commit c31bc9d into bioconda:master Jan 24, 2025
5 checks passed
@jfy133 jfy133 deleted the update-amdirt branch January 24, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants