Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bi-Directional braking as a setting #137

Open
stylesuxx opened this issue Jul 6, 2023 · 2 comments
Open

Bi-Directional braking as a setting #137

stylesuxx opened this issue Jul 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@stylesuxx
Copy link
Contributor

Might be worth a shot to have this as a setting to improve motor direction reversal in 3D mode.

@stylesuxx stylesuxx added the enhancement New feature or request label Jul 6, 2023
@stylesuxx stylesuxx added this to the v0.21.0 milestone Jul 6, 2023
@stylesuxx stylesuxx self-assigned this Jul 8, 2023
@stylesuxx
Copy link
Contributor Author

This change seems to have brought great improvement on smaller quads: be25795 and basically eliminated all de-syncs on motor reversal.

Suggestion: We add this as a setting and allow the user to set this from 0x10 to 0x50. Or even better, show the corresponding eRPM.

@damosvil any thoughts on this?

@stylesuxx stylesuxx changed the title Evaluate if bidir braking would make sense as setting Bi-Directional braking as a setting Jul 8, 2023
@damosvil
Copy link
Contributor

damosvil commented Jul 8, 2023

For now I would give it more time so people can provide feedback on the current change.
I think that previous setting was tested on 14 pole motors, that are bigger and more powerful than the ones @egonl used in their builds during tests. The new setting should help for less powerful and 12 pole motors, in order to avoid stalls during startup, but I would like to wait until it is tested on bigger motors.
If current settings are generic enough for a wider range of motors I would let it with no parameter, because the common user prefers that things just work out of the box. I would add the setting if we receive feedback from people that are uncomfortable with the current version though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants