New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting Beacon Melodies and "variable" PWM #15

Closed

2 tasks done

stylesuxx opened this issue Sep 11, 2022 · 1 comment

Closed

2 tasks done

Splitting Beacon Melodies and "variable" PWM #15

stylesuxx opened this issue Sep 11, 2022 · 1 comment

Contributor

stylesuxx commented Sep 11, 2022 •

edited

Loading

I think it would be a great idea to split #8 (beacon-melody) branch into two separate PR's.

Currently I fail to understand if both features would work on all available MCUs since the build files are edited and commited in a restrictive way.

Create branch for beacon melodies
Create branch for "variable" PWM

Contributor Author

stylesuxx commented Sep 17, 2022

Split to two PRs: #18 #19

stylesuxx closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment