From c8600fb415522dcd952ee2e3d1de9809499f7772 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Fridmansk=C3=BD?= Date: Fri, 14 Jun 2024 08:38:44 +0200 Subject: [PATCH 1/3] fix: type error property is not configurable --- src/components/List/index.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/List/index.tsx b/src/components/List/index.tsx index 6c4730a..98ceda0 100644 --- a/src/components/List/index.tsx +++ b/src/components/List/index.tsx @@ -28,7 +28,6 @@ const StoryList: FC = ( { const animatedStyles = useAnimatedStyle( () => ( { height: imageHeight.value } ) ); const contentStyles = useAnimatedStyle( () => ( { opacity: withTiming( hideElements.value ? 0 : 1 ), - ...ListStyles.content, } ) ); const onImageLayout = ( height: number ) => { @@ -59,7 +58,7 @@ const StoryList: FC = ( { imageProps={imageProps} videoDuration={videoDuration} /> - + {imageOverlayView} Date: Fri, 14 Jun 2024 09:31:09 +0200 Subject: [PATCH 2/3] fix: ref.current?.resume is not a function --- src/components/Image/video.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Image/video.tsx b/src/components/Image/video.tsx index c365a8e..c16db29 100644 --- a/src/components/Image/video.tsx +++ b/src/components/Image/video.tsx @@ -22,7 +22,7 @@ const StoryVideo: FC = ( { const start = () => { ref.current?.seek( 0 ); - ref.current?.resume(); + ref.current?.resume?.(); }; From 002547ba343be6f240d8e16c7e3dd4a6ce521482 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Fridmansk=C3=BD?= Date: Fri, 14 Jun 2024 09:33:20 +0200 Subject: [PATCH 3/3] fix: opening url on footer press causes images to get stuck --- src/components/Content/index.tsx | 2 +- src/components/Footer/index.tsx | 2 +- src/components/Image/index.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Content/index.tsx b/src/components/Content/index.tsx index 5ba6018..6cddf43 100644 --- a/src/components/Content/index.tsx +++ b/src/components/Content/index.tsx @@ -26,7 +26,7 @@ const StoryContent: FC = ( { stories, active, activeStory } ) useAnimatedReaction( () => activeStory.value, ( res, prev ) => res !== prev && onChange(), - [ activeStory.value ], + [ activeStory.value, onChange ], ); const content = useMemo( () => stories[storyIndex]?.renderContent?.(), [ storyIndex ] ); diff --git a/src/components/Footer/index.tsx b/src/components/Footer/index.tsx index 297f9d7..85c6444 100644 --- a/src/components/Footer/index.tsx +++ b/src/components/Footer/index.tsx @@ -26,7 +26,7 @@ const StoryFooter: FC = ( { stories, active, activeStory } ) useAnimatedReaction( () => activeStory.value, ( res, prev ) => res !== prev && onChange(), - [ activeStory.value ], + [ activeStory.value, onChange ], ); const footer = useMemo( () => stories[storyIndex]?.renderFooter?.(), [ storyIndex ] ); diff --git a/src/components/Image/index.tsx b/src/components/Image/index.tsx index 465fc6f..000e530 100644 --- a/src/components/Image/index.tsx +++ b/src/components/Image/index.tsx @@ -68,13 +68,13 @@ const StoryImage: FC = ( { useAnimatedReaction( () => isActive.value, ( res, prev ) => res !== prev && res && runOnJS( onImageChange )(), - [ isActive.value ], + [ isActive.value, onImageChange ], ); useAnimatedReaction( () => activeStory.value, ( res, prev ) => res !== prev && runOnJS( onImageChange )(), - [ activeStory.value ], + [ activeStory.value, onImageChange ], ); const onContentLoad = ( newDuration?: number ) => {