Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing naming between Settings components and Settings pages #218

Open
jarolrod opened this issue Jan 17, 2023 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@jarolrod
Copy link
Member

jarolrod commented Jan 17, 2023

Right now we have completely confusing naming between our Settings components which contain the definition for the ColumnLayout containing the action items that can configure the option; and our Settings pages, which contain the definition for the Page that will contain said setting component

For example:
The file pages/settings/SettingsConnection.qml is a page and inside of here we have a component called ConnectionSettings which resides at components/ConnectionSettings.

SettingsConnection <-> ConnectionSettings

These are the same words, but in reverse order. We need a better naming system; or really a better implementation method.

@jarolrod jarolrod added the good first issue Good for newcomers label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant