Introduce and Use NetworkIndicator component #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jarolrod
force-pushed
the
current-network-indicator
branch
from
bcb3aee to
dd76b6e
Compare
|
Rebase? |
Represents the yellow-orange color used for the NetworkIndicator when the app is running on the Signet network.
Signals to the user what network they are running under when not on the main network.
jarolrod
force-pushed
the
current-network-indicator
branch
from
dd76b6e to
932622e
Compare
jarolrod
force-pushed
the
current-network-indicator
branch
from
932622e to
01b3909
Compare
|
Sorry for the late feedback. A couple of details don't match the design. The font should be 15px, and vertical spacing should be 2 (horizontal remains 7). As is right now, the indicator looks slightly too big compared to everything else. |
hebasto
added a commit
that referenced
this pull request
Feb 13, 2023
e621826 qml: fix NetworkIndicator font size and padding (jarolrod) Pull request description: Addresses [this](#251 (comment)) review feedback, and gets us to fit with the [design file](https://www.figma.com/file/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design?node-id=6010%3A67918&t=N1q0V96d7QISBeRs-4). Overlooked in #251 ### Master | testnet | signet | regtest | | ------- | ------ | ------- | | <img width="752" alt="testnet-master" src="https://user-images.githubusercontent.com/23396902/218172893-9ad1b653-1a25-4fe6-9429-e422b1f799ca.png"> | <img width="752" alt="signet-master" src="https://user-images.githubusercontent.com/23396902/218172938-ac394c8b-608e-444c-89c2-804e953a7b9e.png"> | <img width="752" alt="regtest" src="https://user-images.githubusercontent.com/23396902/218172980-a23d0329-ae53-4719-8d25-f20f8d48cbac.png"> | ### PR | testnet | signet | regtest | | ------- | ------ | ------- | | <img width="752" alt="testnet-pr" src="https://user-images.githubusercontent.com/23396902/218173081-e610be32-c78c-46c9-a741-1e454bbe7a9f.png"> | <img width="752" alt="signet-pr" src="https://user-images.githubusercontent.com/23396902/218173130-483afeb1-bb25-4d53-a9f2-3e2da755ae39.png"> | <img width="752" alt="regtest-pr" src="https://user-images.githubusercontent.com/23396902/218173172-26449e22-5f32-4ad7-8289-5aa5e8d98428.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>) ACKs for top commit: johnny9: ACK e621826 Tree-SHA512: 3094cd1e9fb7f9c0e6e276a80cfa190e9ae80991d6029fdbe793485dcaea76a14e4c5a9734a840b374f04653557d7ca33dd4074020565e81fcef7735abeb080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signals to the user when they are running on a network other than main.
Closes #233
Light
Dark