Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary line breaks #282

Closed
GBKS opened this issue Mar 7, 2023 · 1 comment
Closed

Remove unnecessary line breaks #282

GBKS opened this issue Mar 7, 2023 · 1 comment

Comments

@GBKS
Copy link
Contributor

GBKS commented Mar 7, 2023

The copy in the Figma designs included some custom line breaks to make the shape of the text look nicer (common thing these goofy designers do). These were ported into the code. Since the application width is flexible, this can cause line breaks in awkward places. Let's remove them.

  • Strengthen bitcoin screen, line break between "bitcoin" and "so" (code)
  • Block clock screen, line break between "every" and "10", and "dial" and "that" (code)

Useful skills:

Just some basic text edits.

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
@johnny9 johnny9 mentioned this issue Mar 7, 2023
Merged
hebasto added a commit that referenced this issue Mar 15, 2023
@hebasto
Merge #283: Remove unnecessary line breaks from Onboarding pages
3d3d13b 
1ef15eb qml: remove unnecessary line breaks from Onboarding pages (johnny9)

Pull request description:

  #282

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/283)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/283)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/283)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/283)

ACKs for top commit:
  jarolrod:
    ACK 1ef15eb

Tree-SHA512: 48db83f27e00fe9794dec3c0f2dafcce749ba5cbd87f1380430035eb25f8b41b82ed4c2ea3dc2c397344fcf6b368e88e696c5105695386d0b80c440576d5b3f4
@jarolrod
Copy link
Member

This was fixed by #283

@hebasto hebasto closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GBKS @jarolrod @hebasto