Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings when entering peers page #326

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix warnings when entering peers page #326

merged 2 commits into from
Apr 21, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Apr 21, 2023 •
edited
Loading

Fixes #322

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod added the Bug Something isn't working label Apr 21, 2023
@jarolrod jarolrod mentioned this pull request Apr 21, 2023
Closed
johnny9
johnny9 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 91063ea

hebasto
hebasto approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 91063ea, tested on Ubuntu 23.04 (Qt 5.15.8).

@hebasto hebasto merged commit 251a9b5 into bitcoin-core:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebasto hebasto hebasto approved these changes

@johnny9 johnny9 johnny9 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required property paused was not initialized in PeersIndicator.qml
3 participants
@jarolrod @johnny9 @hebasto