Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce B generic to LocalChain #1497

Closed
notmandatory opened this issue Jul 2, 2024 · 1 comment
Closed

Introduce B generic to LocalChain #1497

notmandatory opened this issue Jul 2, 2024 · 1 comment
Labels
api A breaking API change module-blockchain
Milestone
1.0.0-alpha

Comments

@notmandatory
Copy link
Member

notmandatory commented Jul 2, 2024 •
edited
Loading

Sub-task for #1103
@notmandatory notmandatory added this to BDK Jul 2, 2024
@notmandatory notmandatory converted this from a draft issue Jul 2, 2024
@notmandatory notmandatory added module-blockchain api A breaking API change labels Jul 2, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 2, 2024
@evanlinjin
Copy link
Member

evanlinjin commented Jul 2, 2024 •
edited
Loading

I've realized that this is not needed because we can do LocalChain<B = BlockHash> and then LocalChain will retain the same behavior as the old LocalChain.

Edit: refer to this: #1488 (comment)

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api A breaking API change module-blockchain
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

No branches or pull requests
2 participants
@notmandatory @evanlinjin