Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keychain::ChangeSet::keychains_added and add this to bdk_wallet::ChangeSet #1498

Closed
notmandatory opened this issue Jul 2, 2024 · 4 comments · Fixed by #1514
Closed

Remove keychain::ChangeSet::keychains_added and add this to bdk_wallet::ChangeSet #1498

notmandatory opened this issue Jul 2, 2024 · 4 comments · Fixed by #1514
Assignees
@evanlinjin
Labels
api A breaking API change module-blockchain module-wallet
Milestone
1.0.0-alpha

Comments

@notmandatory
Copy link
Member

notmandatory commented Jul 2, 2024 •
edited
Loading

Sub-task for #1103
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 2, 2024
@notmandatory notmandatory added this to BDK Jul 2, 2024
@notmandatory notmandatory moved this to Todo in BDK Jul 2, 2024
@notmandatory notmandatory mentioned this issue Jul 5, 2024
Closed
@gnapoli23
Copy link
Contributor

@notmandatory Can I pick this one? It should be just a refactor right? If ok I would go for it.

@notmandatory notmandatory moved this from Todo to Needs Review in BDK Jul 8, 2024
@notmandatory notmandatory moved this from Needs Review to Todo in BDK Jul 8, 2024
@notmandatory
Copy link
Member Author

@gnapoli23 thanks for offering to pitch in on this, I need to check with @evanlinjin and make sure he's not doing this in the PR he's working on.

@gnapoli23
Copy link
Contributor

All right, ok please let me know @notmandatory . Thanks.

@evanlinjin
Copy link
Member

Sorry I'm already working on this.

@nondiremanuel nondiremanuel moved this from Todo to In Progress in BDK Jul 16, 2024
@evanlinjin evanlinjin mentioned this issue Jul 17, 2024
Merged
5 tasks
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Jul 18, 2024
@notmandatory notmandatory moved this from Needs Review to In Progress in BDK Jul 18, 2024
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Jul 18, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
api A breaking API change module-blockchain module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

refactor(wallet)!: rework persistence, changeset, and construction evanlinjin/bdk
3 participants
@gnapoli23 @notmandatory @evanlinjin