Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relink not working as intended #49

Open
sschiessl-bcp opened this issue Aug 14, 2022 · 4 comments
Open

Relink not working as intended #49

sschiessl-bcp opened this issue Aug 14, 2022 · 4 comments

Comments

@sschiessl-bcp
Copy link
Collaborator

When executing the same example twice, it asks me also in the second run to decide which account. This UX needs to be re-evaluated as I think it should not ask for account again

https://github.com/bitshares/beet-js/blob/develop/examples/bitshares/signedMessage.js

@grctest
Copy link
Contributor

grctest commented Aug 14, 2022

Started work on improving this relink UX https://github.com/BTS-CM/beet-esm/commit/0ee2b5895fea54c5cfc0561a0cd64204f415ad19

@grctest
Copy link
Contributor

grctest commented Aug 16, 2022

I've created the following pull request to address this concern: #50

I'll update the readme to reference the need to store identity for relink purposes soon.

I've also introduced changes to the beet client, however I ran into some issues creating the pull request: bitshares/beet#185

@grctest
Copy link
Contributor

grctest commented Aug 16, 2022

I've submitted a BEET wallet pull request bitshares/beet#186

I'm now confident that these two pull requests fix the issue you've reported.

@grctest
Copy link
Contributor

grctest commented Sep 19, 2022

Fixed now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants