Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 add conv2d layer #54

Closed
wants to merge 4 commits into from
Closed

15 add conv2d layer #54

wants to merge 4 commits into from

Conversation

mjovanc
Copy link
Member

@mjovanc mjovanc commented Dec 6, 2024 •
edited
Loading

Unit tests fail for conv2d.rs. I get a lot of assertion issues. This is an issue we get:

Self tensor must be 2D for matmul: ShapeError/IncompatibleShape: incompatible shapes
thread 'neuralnet::layers::conv2d::tests::test_conv2d_layer_backward_pass' panicked at delta/src/common/tensor_ops.rs:286:14:
Self tensor must be 2D for matmul: ShapeError/IncompatibleShape: incompatible shapes

@mjovanc mjovanc linked an issue Dec 6, 2024 that may be closed by this pull request
Add Conv2D layer #15
Open
@mjovanc
Copy link
Member Author

mjovanc commented Dec 6, 2024

@chaseWillden Can you take a look at this? I would like a second look since I can't find the issue here.

@mjovanc mjovanc closed this Dec 6, 2024
@mjovanc mjovanc deleted the 15-add-conv2d-layer branch December 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Conv2D layer
1 participant
@mjovanc