Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Intel compiler #17

Open
termoshtt opened this issue Apr 10, 2017 · 7 comments
Open

Add support for the Intel compiler #17

termoshtt opened this issue Apr 10, 2017 · 7 comments

Comments

@termoshtt
Copy link
Member

termoshtt commented Apr 10, 2017

I try to compile this crate with intel-compiler (ifort) and succeed by rewriting dylib specification in build.rs.
https://github.com/termoshtt/openblas-src/pull/1/files
Do you have any plan to support intel compiler?
If you are interest in, I will create PR to introduce intel feature to switch gfortran/ifort.

@IvanUkhov
Copy link
Member

IvanUkhov commented Apr 10, 2017

Thank you for the issue! Yes, it certainly would be great to support different configurations.

I suppose OpenBLAS detected by itself that gfortran was not available and switched to ifort, right? If it’s the case, the way to proceed is to fetch the compiled utilized from OpenBLAS’s log files or something and then link to the right libraries in the build script. I was looking it to this some time ago and was able to do this, but then I dropped that code as I had only one alternative, gfortran, and was not able to test what would happen with other potential compilers.

@IvanUkhov
Copy link
Member

Have a look at the code that I’m removing in this commit.

@termoshtt
Copy link
Member Author

Thanks link!

the way to proceed is to fetch the compiled utilized from OpenBLAS’s log files or something and then link to the right libraries in the build script.

It seems to be more complicated than I intended, but it is feasible as you did.
My concern is that it is hard to test on CI using ifort since there is no option to use Intel compiler on CI as I sought. If I create gfortran/ifort switch, it will be tested only on my environment.
Does this crate permit this?

@IvanUkhov
Copy link
Member

Yes, I think it’s worth it. There will be at least one confirmation that it’s working as intended.

@termoshtt
Copy link
Member Author

Ok, I will create it. Thanks!

@IvanUkhov
Copy link
Member

@termoshtt, is this still relevant?

@termoshtt
Copy link
Member Author

is this still relevant?

Thanks for notification. The above link is out-of-date completely. But Intel compiler support is still a valid issue.

  • Since the OpenBLAS build system must support icc/ifort, we can use it through openblas-build.
  • A remaining problem is how to test it on CI.

@IvanUkhov IvanUkhov changed the title Intel compiler support Add support for the Intel compiler Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants