Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall-devices fails early #12

Open
edbaunton opened this issue Jul 24, 2019 · 1 comment
Open

uninstall-devices fails early #12

edbaunton opened this issue Jul 24, 2019 · 1 comment

Comments

@edbaunton
Copy link
Contributor

Currently if your chroot gets into a bad state where not all the devices were cleanly uninstalled, you cannot easily fix it. The --uninstall-devices is
not best effort and bails after failing the first one.

For example, /dev/shm can be busy so when it is attempted to be unlinked it fails. This then leaves all the other devices installed.

Expected behavior
--uninstall-devices does not give up as soon as the first uninstall fails. Rather it should warn and then ultimately return non-zero.

@juergbi
Copy link
Contributor

juergbi commented Nov 26, 2019

The /dev/shm issue should be solved by #14. However, I agree, --uninstall-devices should still not fail early.

juergbi added a commit to juergbi/userchroot that referenced this issue Dec 17, 2019
juergbi added a commit to juergbi/userchroot that referenced this issue Jan 5, 2020
juergbi added a commit to juergbi/userchroot that referenced this issue Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants