Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run slow tests with a large database on CI #604

Open
3 tasks
danielballan opened this issue Nov 14, 2023 · 0 comments
Open
3 tasks

Run slow tests with a large database on CI #604

danielballan opened this issue Nov 14, 2023 · 0 comments
Labels

Comments

@danielballan
Copy link
Member

In #588 we added a test that places 10k rows in the nodes table, in order to effectively exercise an index.

We followed a common pytest pattern for slow tests: adding slow marker to the test, and adding -m 'not slow' to our pytest invocation.

To run this test---and perhaps future ones like it---on CI, we should:

  • Move the creation of that large database into a dedicated fixture that has a stable database name, rather than uuid4, and uses an existing database if it exists
  • On CI, mount an external volume in the container for postgres data.
  • Cache the volume between CI runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant