-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 1(Bokeh gallery) Outreachy contributions-Joy Akinyi #33
Comments
Hi Joy, thanks for the update, we can definitely count this work towards the microtask completion. However, this particular example was already updated by another participant in a PR last week bokeh/bokeh#12953 so if you intend to make a Pull Request against the main repo, it would be good to select another example that has not already been recently changed. A couple of comments:
|
Hello @bryevdv Thank you for the much needed feedback! I am definitely looking forward to updating more plots. Well for the xtick labels I was thinking maybe for space efficiency it would be convenient to have them at 90 degrees since they'll take up less horizontal space on the plot. |
This is definitely a valid thing to consider for sure! Another idea might be to simply swap the axes, so that the labels can just be horizontal and very easy to read. But then it would be a very "tall" plot and also I think (this is speculation on my part) the most people have an easier time judging differences in height of vertical bars, than they would judging length of horizontal bars. But depending on the chart it still might make sense to swap axe to have horizontal axis labels. There are always trade-offs to consider! |
@bryevdv @pavithraes Yeah i was having the same thoughts too....they'd look "tall" and most people are familiar with the bars being plotted vertically not horizontally,thats why i opted for changing the angles of the the xticks.I have also updated another plot,You can find the link to the gist here.Attached is the updated plot. Kindly Advice on whether i should request a PR |
@bryevdv @pavithraes
My github gist has the codes i used to update bokeh gallery plots . I also set up my local environment as seen in the attached file.Additionally,I will also continue to update the plots and give more solutions in regards to this project.The first plot is as it is in the gallery while the second plot is my updated plot
The text was updated successfully, but these errors were encountered: