Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect calculation of (# of days).business_days.before(DATE) #141

Closed
AAlvarez90 opened this issue Oct 5, 2016 · 2 comments
Closed

Incorrect calculation of (# of days).business_days.before(DATE) #141

AAlvarez90 opened this issue Oct 5, 2016 · 2 comments

Comments

@AAlvarez90
Copy link

AAlvarez90 commented Oct 5, 2016 •
edited
Loading

For example, if DATE is a Sunday, then:

1.business_days.before(DATE_SUNDAY) = Thursday.

Which is wrong, it should take me to the previous Friday. So it's going 1 extra business days back in time.

PS:
This offset is happening only when DATE is a weekend, if it's a week day it works fine.
@xlts
Copy link
Contributor

xlts commented Oct 8, 2016 •
edited
Loading

@AAlvarez90 it's a known behavior and is being discussed in #116 (this applies to your other issue as well); however it doesn't seem to be changed anytime soon.

@bokmann
Copy link
Owner

bokmann commented Apr 1, 2017

Closing because tthis is a dup of #116. I believe the discussion happening in #126 applies here as well.

@bokmann bokmann closed this as completed Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bokmann @AAlvarez90 @xlts