-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of :preprocess given recent updates #179
Comments
I think I got close, but got this error: |
You need to run |
I see. That makes sense. I made some further progress by removing the folder containing the js to compile out of my I couldn't manage to require react 15 (from node_modules) from that external js though however. I'd be quite happy to require the cljsjs.React, but that didn't seem possible either. The error I saw was this:
|
Looks like you are trying to require React (CommonJS) from ES6 module. That doesn't work currently: google/closure-compiler#2634 And foreign libs (cljsjs) are Cljs only, so they can't be used from module processing modules. |
Okay, so if I convert the code to be commonjs throughout, that seems to be working. Unless I end up depending on a module which uses ES6 modules, I guess? (I'm not sure if that can happen) I thought they might be cljs only, but figured I'd ask regardless. I have this working now, which is great! Things that seem to be missing:
Are these things that boot-cljs should/would fix? Shall I open specific issue(s) to track them? |
You can depend on most ES6 modules, but not on those ES6 modules that use CJS. CommonJS -> ES6 Works I have only looked into case where using existing Node packages, which are always under |
continuation of #151
One annoyance is that
:file
in:foreign-libs
is not prefixed on the classpath automatically to the relevant boot tmp files.The text was updated successfully, but these errors were encountered: