Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests leave key in keyring. #1215

Open
real-yfprojects opened this issue Mar 6, 2022 · 5 comments · May be fixed by #1639
Open

Tests leave key in keyring. #1215

real-yfprojects opened this issue Mar 6, 2022 · 5 comments · May be fixed by #1639
Assignees
@ganeshrevadi
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it priority:low Nice to have feature, minor improvement to functionality or usability type:task A TODO

Comments

@real-yfprojects
Copy link
Collaborator

The issue was first brought up by @bastiencyr in #1065:

Only for dev, I just noticed that there are a lot of keys added in my repo manager which start by "vorta-test-repo...". I don't know if it is a bug but it would be nice for dev to provide a way to remove this tests repo. I have something like 650 entries 'vorta-test-repo...' in my default password manager (gnome-keyring) :(

To solve this issue, the keyring module of vorta needs a method to remove a key from the keyring. Currently I don't know of other uses of such a feature.
@real-yfprojects real-yfprojects added priority:low Nice to have feature, minor improvement to functionality or usability good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it labels Apr 9, 2022
@stale
Copy link

stale bot commented Jun 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label Jun 10, 2022
@stale stale bot removed the status:stale This item will be closed soon due to inactivity label Jun 11, 2022
swapnil290502 added a commit to swapnil290502/vorta that referenced this issue Feb 6, 2023
@swapnil290502
swapnil290502
4bd132a 
borgbase#1215 solved
removed key from keyring
@swapnil290502 swapnil290502 mentioned this issue Feb 6, 2023
Open
swapnil290502 added a commit to swapnil290502/vorta that referenced this issue Feb 6, 2023
@swapnil290502
swapnil290502
870aa14 
borgbase#1215  solved
removed key from keyring
@swapnil290502 swapnil290502 mentioned this issue Feb 6, 2023
Closed
@ganeshrevadi
Copy link
Contributor

Is this issue just refers to removing key =lambda k: k[1] from get_keyring() in vorta/src/vorta/keyring/abc.py
@real-yfprojects

@real-yfprojects
Copy link
Collaborator Author

real-yfprojects commented Mar 5, 2023 •
edited
Loading

Nope, see above and also this comment: #1584 (comment)

Do you want to tackle this issue?

@ganeshrevadi
Copy link
Contributor

I can work on the issue , I understand that their needs to be a method remove_password added in the abc.py and its implementation in corresponding files . Its a little complicated for me , if you could guide me through on how it work and what will be its usecases?

@real-yfprojects
Copy link
Collaborator Author

I understand that their needs to be a method remove_password added in the abc.py and its implementation in corresponding files.

Yes, start with defining the abstract method signature in abc.py. Then implement it for each password provider and adjust the abstract signature as needed. I suggest you start with secretstorage and do MacOS last.

When that works you can write test coverage for the new function and use it to clean up existing tests.

Its a little complicated for me , if you could guide me through on how it work

No problem, I will do that. Just ask if run into an issue.

what will be its usecases?

Currently we'll only use it for cleaning up tests.

@real-yfprojects real-yfprojects linked a pull request Jun 27, 2023 that will close this issue
Tests leave key in keyring #1639
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganeshrevadi ganeshrevadi

Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it priority:low Nice to have feature, minor improvement to functionality or usability type:task A TODO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests leave key in keyring ganeshrevadi/vorta
2 participants
@real-yfprojects @ganeshrevadi