From be779d1b9bf4ec01ebb0d3d0f7304cda1084c217 Mon Sep 17 00:00:00 2001 From: zajck Date: Thu, 14 Sep 2023 14:05:50 +0200 Subject: [PATCH] enable back initialization checks --- contracts/protocol/bases/ProtocolBase.sol | 2 +- .../protocol/facets/ProtocolInitializationHandlerFacet.sol | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/protocol/bases/ProtocolBase.sol b/contracts/protocol/bases/ProtocolBase.sol index e34f99ca7..6ed2bf5c1 100644 --- a/contracts/protocol/bases/ProtocolBase.sol +++ b/contracts/protocol/bases/ProtocolBase.sol @@ -20,7 +20,7 @@ abstract contract ProtocolBase is PausableBase, ReentrancyGuardBase { */ modifier onlyUninitialized(bytes4 interfaceId) { ProtocolLib.ProtocolStatus storage ps = protocolStatus(); - // require(!ps.initializedInterfaces[interfaceId], ALREADY_INITIALIZED); + require(!ps.initializedInterfaces[interfaceId], ALREADY_INITIALIZED); ps.initializedInterfaces[interfaceId] = true; _; } diff --git a/contracts/protocol/facets/ProtocolInitializationHandlerFacet.sol b/contracts/protocol/facets/ProtocolInitializationHandlerFacet.sol index cc9354a37..0e15675ca 100644 --- a/contracts/protocol/facets/ProtocolInitializationHandlerFacet.sol +++ b/contracts/protocol/facets/ProtocolInitializationHandlerFacet.sol @@ -22,7 +22,7 @@ contract ProtocolInitializationHandlerFacet is IBosonProtocolInitializationHandl */ modifier onlyUninitializedVersion(bytes32 _version) { ProtocolLib.ProtocolStatus storage ps = protocolStatus(); - // require(!ps.initializedVersions[_version], ALREADY_INITIALIZED); + require(!ps.initializedVersions[_version], ALREADY_INITIALIZED); ps.initializedVersions[_version] = true; _; } @@ -154,7 +154,7 @@ contract ProtocolInitializationHandlerFacet is IBosonProtocolInitializationHandl */ function initV2_3_0(bytes calldata _initializationData) internal { // Current version must be 2.2.1 - // require(protocolStatus().version == bytes32("2.2.1"), WRONG_CURRENT_VERSION); + require(protocolStatus().version == bytes32("2.2.1"), WRONG_CURRENT_VERSION); require(protocolCounters().nextTwinId == 1, TWINS_ALREADY_EXIST); @@ -173,7 +173,7 @@ contract ProtocolInitializationHandlerFacet is IBosonProtocolInitializationHandl emit MinResolutionPeriodChanged(_minResolutionPeriod, msgSender()); // Deploy a new voucher proxy - // protocolAddresses().beaconProxy = address(new BeaconClientProxy{ salt: VOUCHER_PROXY_SALT }()); + protocolAddresses().beaconProxy = address(new BeaconClientProxy{ salt: VOUCHER_PROXY_SALT }()); } /**