Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make GroupLayer a LayerList for rendering purposes? #11

Closed
willGraham01 opened this issue Jun 18, 2024 · 3 comments · Fixed by #30
Closed

[Feature] Make GroupLayer a LayerList for rendering purposes? #11

willGraham01 opened this issue Jun 18, 2024 · 3 comments · Fixed by #30
Labels
enhancement New feature or request

Comments

@willGraham01
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We can likely obtain a large amount of functionality from having GroupLayer also be a LayerList, however the difficulty lies in the fact that we cannot edit the underlying napari core code, and our GroupLayer at current wraps Layers in Nodes, which means a straight LayerList mixin won't work.

Describe the solution you'd like

The GroupLayer object should have the functionality of the current LayerList - toggles for visibility, relative reordering, etc.

Describe alternatives you've considered

Additional context
@willGraham01 willGraham01 added the enhancement New feature or request label Jun 18, 2024
@willGraham01 willGraham01 self-assigned this Jun 18, 2024
@K-Meech
Copy link
Contributor

K-Meech commented Jun 26, 2024

Just a note that styling may be fixed as part of #10 . In order to add a right click menu, I'm making a sub-class from LayerDelegate which brings a lot of functionality / styling with it.

@willGraham01
Copy link
Contributor Author

As @K-Meech said above, this will be fixed with the implementation on km/right-click along with #10. Leaving open for now

@willGraham01 willGraham01 assigned K-Meech and unassigned willGraham01 Jul 2, 2024
@K-Meech K-Meech mentioned this issue Jul 4, 2024
Merged
7 tasks
@willGraham01 willGraham01 linked a pull request Jul 5, 2024 that will close this issue
Allows toggling visibility of group layers #30
Merged
7 tasks
@willGraham01
Copy link
Contributor Author

Closing as implemented with #29 - we now inherit the LayerDelegate formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allows toggling visibility of group layers brainglobe/napari-experimental
2 participants
@K-Meech @willGraham01