Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu component #368

Open
petemill opened this issue Aug 31, 2023 · 0 comments · Fixed by #383
Open

Menu component #368

petemill opened this issue Aug 31, 2023 · 0 comments · Fixed by #383
Assignees

Comments

@petemill
Copy link
Member

petemill commented Aug 31, 2023

Let's take the menu-ness from Dropdown and offer it as a standalone component. @fallaciousreasoning 's idea is that the anchor would be provided via a slot.

How about we have the following component names?

  • Floating - popover stuff, mostly provided by floating-ui
  • Menu - list of items that is anchored to something (props: isOpen, target)
  • Dropdown - opens a menu anchored to the dropdown input
  • ButtonMenu - opens a menu when a button is clicked

Things Dropdown can keep that ButtonMenu doesn't really need:

  • Extracting the text from an option
  • Providing a change event to the consumer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants