You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In brave/brave-core#25764 I've been migrating over to the navigation component. There are a few issues I've encountered:
Active Navigation entry isn't highlighted
If you nest a NavigationItem in a Navigation everything works but you get a weird • before the NavigationItem - if you add a NavigationMenu inside the Navigation it looks okay
NavigationItem icons can only be set via a property, instead of via a slot, like in other components
Storybook doesn't document the props on NavigationItem or NavigationMenu and it's kinda hard to guess how to use the component.
isCurrent isn't implied by the current window hash matching the current NavigationItem href
In brave/brave-core#25764 I've been migrating over to the navigation component. There are a few issues I've encountered:
NavigationItem
in aNavigation
everything works but you get a weird•
before theNavigationItem
- if you add aNavigationMenu
inside theNavigation
it looks okayNavigationItem
icons can only be set via a property, instead of via a slot, like in other componentsNavigationItem
orNavigationMenu
and it's kinda hard to guess how to use the component.isCurrent
isn't implied by the current window hash matching the currentNavigationItem
hrefcc @AlanBreck
The text was updated successfully, but these errors were encountered: