Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation]: Navigation component works slightly differently to other components #847

Open
fallaciousreasoning opened this issue Oct 2, 2024 · 0 comments
Assignees

Comments

@fallaciousreasoning
Copy link
Collaborator

fallaciousreasoning commented Oct 2, 2024

In brave/brave-core#25764 I've been migrating over to the navigation component. There are a few issues I've encountered:

  1. Active Navigation entry isn't highlighted
  2. If you nest a NavigationItem in a Navigation everything works but you get a weird before the NavigationItem - if you add a NavigationMenu inside the Navigation it looks okay
  3. NavigationItem icons can only be set via a property, instead of via a slot, like in other components
  4. Storybook doesn't document the props on NavigationItem or NavigationMenu and it's kinda hard to guess how to use the component.
  5. isCurrent isn't implied by the current window hash matching the current NavigationItem href

cc @AlanBreck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant