Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style guidelines (discussion topic) #81

Open
vi-to opened this issue Mar 22, 2019 · 0 comments
Open

Coding style guidelines (discussion topic) #81

vi-to opened this issue Mar 22, 2019 · 0 comments
Labels

Comments

@vi-to
Copy link
Contributor

vi-to commented Mar 22, 2019

Hi!

There is a question I am curious to ask since I first viewed your repository, hope this is the right place to ask so everyone can benefit from it.

Going through many of your functions, I have found inconsistencies with respect to usual R coding conventions, such as Google's R Style Guide. To be fair, while submitting new pull requests, I have sometimes omitted to apply them myself in order to avoid the "whitespace problem".

This is a subjective topic, but I would like to put it in what may hopefully become constructive. My fundamental question is: do you have a favorite coding style that may be a guideline to consistently enforce across the package? If yes, would you like to share it?

Chiefly, I am interested in this because it may be the case you actually prefer new code to be written that way, but comments about what a contributor is allowed to (occasionally) do with the existing code will be much appreciated too. (As for now I am not proposing such big changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants