Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds checking in draw_horizontal_line #7

Open
sharpie7 opened this issue May 28, 2022 · 1 comment
Open

Bounds checking in draw_horizontal_line #7

sharpie7 opened this issue May 28, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sharpie7
Copy link
Contributor

draw_horizontal_line doesn't check its bounds correctly and can stamp over memory outside the bitmap.

The vertical position isn't checked before attempting to draw the line.

The horizontal position is clipped to max of width and should be clipped to width-1.

@breakintoprogram
Copy link
Owner

@sharpie7 it was a quick demo knocked up in an afternoon to test the capabilities. I'll be adding some more graphics primitives in due course and will fix the clipping whilst I'm at it.

@breakintoprogram breakintoprogram self-assigned this Sep 26, 2024
@breakintoprogram breakintoprogram added the bug Something isn't working label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants