Forward AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY to worker hosts

[russki]

Super excited to see the support for env variables for authentication.

Would love to stop sending --s3key and --s3secret arguments in the jobs so that they're not showing up in --resfile & --csvfile files in plain text

But it doesn't seem like elbencho forwards these env variables to the worker --hosts

Is it possible to either

• stop writing out s3key/s3secret in resfile & csvfile in plain text?
  • maybe that can be behind an optional flag

or

• forward AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY to worker hosts automatically if they're set in the elbencho job run

[breuner]

Thanks for mentioning the problem with the credentials from environtment variables, @russki . I'll look into this.

[breuner]

Hi @russki , thanks again for mentioning this proble.m The latest stable release v3.0.21 from today now also sends the AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY from the master's environment variables to the service instances like you suggested.

You've also sent #71, which of course also makes sense. I'm thinking that there shouldn't even be an extra option needed to hide the s3 secret, but that the secret should just never get printed in the log or csv file. So instead of accepting your current pull request, I would rather change this to always hide the secret and thus not have an additional option for credential hiding. What you do think about this?

[russki]

@breuner awesome news! thanks!

pushed the new commit to not print keys at all