Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to upload files? #2

Open
iamxvbaba opened this issue Feb 3, 2024 · 3 comments
Open

How to upload files? #2

iamxvbaba opened this issue Feb 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@iamxvbaba
Copy link

No description provided.

@briannadoubt
Copy link
Owner

briannadoubt commented Aug 23, 2024

Hey there. I am working on a more scalable version of this library that is simpler, with a more modern set of features. File handling/uploads will be a part of that. I will push up a branch with these changes some time in the next couple weeks, and would love any input.

The reason it didn't happen in this version is because of the different methods for uploading-- http body vs multipart-form upload. To match behavior with the JS PocketBase client, the "create" and "update" requests need to be content-aware and upload the data with multi-form if there is an image included (else use the request body). The way the previous library was pieced together with Alamofire made this less than ideal to maintain.

@briannadoubt briannadoubt self-assigned this Sep 19, 2024
@briannadoubt briannadoubt added the enhancement New feature or request label Sep 19, 2024
@briannadoubt
Copy link
Owner

v0.2.1 has been released and we will be working towards file handling next. This is being prioritized thanks to your comment @iamxvbaba! Thank you!

@briannadoubt
Copy link
Owner

Working to get this repo more fully tested before getting started on the file upload handling. Rest assured, this change is coming in the next couple months (if all goes to plan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants