Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gamajo/template-loader. #24

Open
schlessera opened this issue Oct 10, 2016 · 1 comment
Open

Remove gamajo/template-loader. #24

schlessera opened this issue Oct 10, 2016 · 1 comment

Comments

@schlessera
Copy link
Member

Remove depedency on gamajo/template-loader and directly provide such functionality through the brightnucleus/view component.

Sorry, @GaryJones, not that there is anything wrong with gamajo/template-loader, I just want to try to get rid of all external dependencies from the base brightnucleus/* components in order to be confident in using them for a public plugin. The risk of encountering a version conflict is just too high.
@GaryJones
Copy link
Contributor

All good.

The new get_theme_file_path() can pretty much replicate the behaviour anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlessera @GaryJones