Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix window differences beteem dev and prod #473

Merged
merged 4 commits into from
May 16, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented May 14, 2024

  • Adds the difference between the browser window in development and production back into the Electron process
  • IS_DEV now checks whether or not the Electron app is packaged

@RobertGemmaJr RobertGemmaJr self-assigned this May 14, 2024
@RobertGemmaJr RobertGemmaJr linked an issue May 14, 2024 that may be closed by this pull request
@RobertGemmaJr RobertGemmaJr requested review from eldu and anna-murphy May 14, 2024 17:43
Copy link

github-actions bot commented May 14, 2024

Visit the preview URL for this PR (updated for commit 5acf003):

https://ccv-honeycomb--pr473-fix-window-9v2qtxzr.web.app

(expires Thu, 23 May 2024 19:05:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr added the 4.0 Versioning: Issue in regards to version 4.0.0 release label May 14, 2024
@RobertGemmaJr RobertGemmaJr requested a review from broarr May 15, 2024 13:44
@RobertGemmaJr RobertGemmaJr merged commit 4aeb7bd into type-module May 16, 2024
7 checks passed
@RobertGemmaJr RobertGemmaJr deleted the fix-window branch May 16, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 Versioning: Issue in regards to version 4.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use app.isPackaged for working with dev/produciton
2 participants