Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple upgrade proposals #22

Open
pharr117 opened this issue Sep 12, 2023 · 0 comments
Open

Handle multiple upgrade proposals #22

pharr117 opened this issue Sep 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@pharr117
Copy link
Contributor

Currently, the code finds the first upgrade proposal and uses that when reaching out to the /cosmos/gov/v1beta1/proposals?proposal_status=2 endpoint:

https://github.com/DefiantLabs/cosmos-upgrades/blob/18197052b24f9d07ddc1a9b0b8b9c80b1979d5e1/app.py#L272-L278

We should handle multiple upgrade proposals in case a chain has multiple active proposals being voted on.

We should consider whether the object data type is the best response value and maybe instead return an array of upgrade proposals in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant