-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to manage light
and dark
mode together. (Issue with text directly on the Background level)
#22
Comments
I will look into that bug... For dark vs light mode. For the aws-orange theme, there is somewhat builtin support for dark mode. You can set a variable to enable dark mode, and it will use a different color scheme. !$PUML_MODE="dark" However, this is not automatic based on system/application setting. This probably is easy to add, especially for aws-orange. However, is the @media (prefers-color-scheme:dark) {} fully working in plantuml now? Last I saw it will still being worked on |
So for this particular problem, and I suspect it is the same for the other problems, is that the styling for that particular syntax uses the same styling as other actions. For example, the below snippet has "First" and "Second". I believe both of these use the same styling. If I am incorrect, then please let me know how to differentiate. I think the only way around this is to use inline coloring as shown for Second below. I tried to use custom styling, but I was getting an error when used with !theme cerulean
See here for example: http://www.plantuml.com/plantuml/umla/SoWkIImgAStDuL8ioKZDJLL8JYqgpKbDpEFYKb2mSiiiAYwnvkAoiadEpyaliahAIKpEjWjEJSxFIwdbSaZDIm7g1000 |
Hi @bschwarz, and all,
After style enhancement (from V1.2023.7beta4) with: Here is a proposal to manage @startuml
'!$BGCOLOR = black
!$BGCOLOR = white
!theme cerulean
<style>
.continuous {
FontColor $PRIMARY_DARK
}
</style>
title Stylish continuous
:a;
:action text 1; <<continuous>>
:action text 2}
@enduml [We might perhaps have to do the same for (all elements directly on the Background level):
Thanks to PlantUML team and @arnaudroques. 👍 |
Are you suggesting that the themes themselves would define the .continuous style? Or each user would have to do that? |
The main question are:
And point of attention:
Regards, |
Hi @bschwarz,
FYI, from an issue reported by Boshka:
[Another wanted feature will be perhaps to manage also
light
anddark
mode together, with (why not...):See: plantuml/plantuml#882
Or another solutions...
]
Regards.
[FYI @arnaudroques]
The text was updated successfully, but these errors were encountered: