Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swimlanes styling #7

Open
GauntletPL opened this issue Sep 23, 2020 · 4 comments
Open

Swimlanes styling #7

GauntletPL opened this issue Sep 23, 2020 · 4 comments

Comments

@GauntletPL
Copy link

In the new Activity Diagram syntax, there is a feature of grouping activities under the Swimlanes. Those Swimlanes are not addressed by the themes:

image

@bschwarz
Copy link
Owner

bschwarz commented Oct 2, 2020

Sorry for the late reply. I will take a look. Do you happen to have the plantuml file that generated the above image? So I can see exactly what you are talking about.

Thanks
Brett

@GauntletPL
Copy link
Author

I don't have exactly that .puml any more, but this should be close enough:

@startuml

title Activity Diagram Title

|Mobile App|
start
    :Navigate to selected reward;
    :Claim selected reward;
    |System in the middle|
    :Validate redemption (*);
        |Target system|
        :Issue claimed reward;
stop

@enduml

@bschwarz
Copy link
Owner

bschwarz commented Oct 4, 2020

Ok, I added the following:

  • BorderColor $INFO
    
  • BorderThickness 2
    
  • TitleBackgroundColor  $SECONDARY_LIGHT-$SECONDARY
    
  • TitleFontColor $PRIMARY
    

There is a new example diagram for swimlane now, it's the second diagram under each theme.

Let me know if this is what you were looking for or not. Any feedback about the colors too will help.

Cheers,
Brett

@GauntletPL
Copy link
Author

Thank you Brett for the provided changes. they look pretty neat.
One issue that I can see, however, is that with the background colour approach, the background box is sticking out unaesthetically beyond the rightmost vertical line. Maybe it'd be better to drop the background colour altogether and just rely on the appropriate font accentuation.

Below is my, rather poor attempt at illustration of what I mean (just made the font bigger and bold):

image

Either way, I'll be fine with whatever approach you'll decide to go on with ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants