You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two things that were missed in the ockam_transport_ble review that we should be sure not to miss for new crates (for example ockam_transport_smoltcp in #2213):
No CHANGELOG.md file. Initially, it should be empty. It's possible this should instead be handled by the changelog generation script.
More broadly, there are certainly other things to check as well. We should make a list of these somewhere. It probably is too rare that we add new crates to be worth automating, but perhaps that's worthwhile too.
We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.
The text was updated successfully, but these errors were encountered:
Two things that were missed in the
ockam_transport_ble
review that we should be sure not to miss for new crates (for exampleockam_transport_smoltcp
in #2213):CHANGELOG.md
file. Initially, it should be empty. It's possible this should instead be handled by the changelog generation script.path = ...
and noversion = ...
for the dependency onockam
(chore(rust): fixupockam_transport_ble
for publish (missing crate version) #2525). This failure manifests quite late in the process, and not during a part that handles interruption well so it's pretty important we catch this one in the future.More broadly, there are certainly other things to check as well. We should make a list of these somewhere. It probably is too rare that we add new crates to be worth automating, but perhaps that's worthwhile too.
We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.
The text was updated successfully, but these errors were encountered: