Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream's tests #1

Open
Klaim opened this issue Feb 22, 2020 · 4 comments
Open

Add upstream's tests #1

Klaim opened this issue Feb 22, 2020 · 4 comments

Comments

@Klaim
Copy link
Collaborator

Klaim commented Feb 22, 2020

Currently the only test implemented will just try to build the Readme code from v3.3.0

Add tests from upstream/tests/...
These tests require gtest (see https://github.com/build2-packaging/googletest we have a package but it lacks gmock support at the moment).

@Wmbat
Copy link
Contributor

Wmbat commented Aug 15, 2022

gtest is now packaged in cppget, we should explore this further !

@Klaim
Copy link
Collaborator Author

Klaim commented Jan 6, 2023

Going back to this:

Edit: updated following the discussion

I will ignore the benchmarks for now.

  • A special attention need to be done for some of the options/macros because they seem to be important, for examlpe the presence or not of ENTT_HAS_HEADER_VERSION;
  • There is something that looks like a basic ODR check in there that all the tests requires, not sure what this is about exactly but seems like it can be done easilly.

I believe that covers everything https://github.com/skypjack/entt/blob/v3.11.1/test/CMakeLists.txt , please tell me if I'm missing something @skypjack

@skypjack
Copy link

skypjack commented Jan 6, 2023

@Klaim I think we can ignore lib and cereal as well as the benchmark and a few others maybe?
These are extra tests for specific purposes. However, the main testsuite covers more or less everything already.
Also consider that all the ones above are enabled or disabled via cmake using a few options. It's easy to ignore them in case.

@Klaim
Copy link
Collaborator Author

Klaim commented Jan 6, 2023

@skyjpack Thanks for the info. Ok so we will focus on the normal tests, make them by default and just make a separate ticket for if someone wants to add more of the upstream tests.

We have a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants